Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vulnerable dependencies #607

Closed
AyanSinhaMahapatra opened this issue Oct 16, 2023 · 4 comments · Fixed by #611
Closed

Update vulnerable dependencies #607

AyanSinhaMahapatra opened this issue Oct 16, 2023 · 4 comments · Fixed by #611
Assignees
Labels
dependencies Pull requests that update a dependency file nice to have version4 Issue for v4

Comments

@AyanSinhaMahapatra
Copy link
Member

from @pombredanne

We could have some vulnerable dependencies and it would be nice to review if we can
update our dependencies.

For example currently on https://github.com/nexB/scancode-workbench/tree/feature/unittests
if we run npm install we have

28 vulnerabilities (5 moderate, 22 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

There are 3 sources where we can check for potential vulnerabilities:

1, We should update these packages that show up on npm install
2. We also should look at dependabot notifications for the same thing.
3. And another thing could be to run SCIO pipelines to get purls and look up vulnerabilities for workbench (and maybe compare them across npm and dependabot :P )

This would be nice to have before the stable release.
Other non-vulnerable dependency upgrades should be also something we can look at potentially,
these could have useful updates and upgrades too.

@AyanSinhaMahapatra
Copy link
Member Author

See the scan results and screenshot from SCIO for reference:
vuln-workbench
scancodeio_workbench-deps-v2-feature-unittests.json
Vulnerable deps as reported by SCIO:

@OmkarPh
Copy link
Collaborator

OmkarPh commented Nov 4, 2023

Finally fxed all vulnerabilities !!

image

@OmkarPh
Copy link
Collaborator

OmkarPh commented Nov 4, 2023

I've built and tested dev as well as release application.
Just to be on a safer side, you can try one of these https://github.com/OmkarPh/scancode-workbench/releases/tag/v4.0.0-vulnerability-fixes

@OmkarPh
Copy link
Collaborator

OmkarPh commented Nov 6, 2023

verified in scancode.io too

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file nice to have version4 Issue for v4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants