Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-inspector processes certain dependencies for way too long #106

Open
bennati opened this issue Dec 12, 2022 · 17 comments
Open

Python-inspector processes certain dependencies for way too long #106

bennati opened this issue Dec 12, 2022 · 17 comments
Labels
bug Something isn't working must have

Comments

@bennati
Copy link
Contributor

bennati commented Dec 12, 2022

Python inspector takes too much time to process certain requirements.txt

For example, the time to process these requirements is more than 1 hour, while the time to process each individually is less than 5 minutes:
``
boto3==1.10.16
s3fs
tabulate


and

boto3==1.10.16
s3fs
seaborn


Could it be caused by cyclical dependencies?
@pombredanne
Copy link
Member

Thanks for the report. Can you tell which target OS-arch and Python version you have used?
And which OS-arch and Python version you used to run python-inspector?

@bennati
Copy link
Contributor Author

bennati commented Dec 13, 2022

Hi, python inspector was run as follows:

python-inspector --python-version 310 --operating-system linux --json-pdt /...json --analyze-setup-py-insecurely --requirement .../src/requirements.txt --verbose

The host architecture is Linux and python 3.10

@pombredanne
Copy link
Member

@bennati Thanks. The --analyze-setup-py-insecurely flags means things are live evaluated. We need to enable a verbose mode to trace what's going on.

@pombredanne
Copy link
Member

there is some sorts of inifite loop IMHO

@pombredanne pombredanne added bug Something isn't working must have labels Dec 13, 2022
@pombredanne
Copy link
Member

The culprit may be https://github.com/mwaskom/seaborn/blob/v0.8.1/setup.py but tabulate looks rather bland.

@bennati
Copy link
Contributor Author

bennati commented Dec 21, 2022

Any update on this? can I help somehow?

@pombredanne
Copy link
Member

@bennati no update yet. Help would be mucho welcomed!

@bennati
Copy link
Contributor Author

bennati commented Dec 23, 2022

Opened PR upstream at resolvelib sarugaku/resolvelib#113

@pombredanne
Copy link
Member

@bennati you rock! 🙇

@bennati
Copy link
Contributor Author

bennati commented Jan 4, 2023

Also related #110

@pombredanne
Copy link
Member

sarugaku/resolvelib#113 by @bennati has been merged 🙇 ❤️ ... so we could likely start using it ASAP with "build from git"?... or wait a bit for a tag?

@bennati
Copy link
Contributor Author

bennati commented Feb 6, 2023

I would prefer asap… I was looking into submitting a PR which would use the latest resolvlib, but it seems to be an indirect dependency and I could not figure out which direct dependency to update

@pombredanne
Copy link
Member

@bennati
Copy link
Contributor Author

bennati commented Feb 7, 2023

ok thanks, it looks like I had a typo in my search :)

bennati added a commit to bennati/python-inspector that referenced this issue Feb 7, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
bennati added a commit to bennati/python-inspector that referenced this issue Feb 7, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
bennati added a commit to bennati/python-inspector that referenced this issue Feb 23, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
bennati added a commit to bennati/python-inspector that referenced this issue Mar 17, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
bennati added a commit to bennati/python-inspector that referenced this issue Mar 17, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
bennati added a commit to bennati/python-inspector that referenced this issue Mar 17, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
@sschuberth
Copy link
Contributor

Hmm, apparently python-inspector 0.9.6 was published to PyPI yesterday which is supposed to fix this issue, but there is no such release yet at https://github.com/nexB/python-inspector/releases. @TG1999 can we please also get a GitHub release entry with release notes to be able to close this in good conscience?

@TG1999
Copy link
Contributor

TG1999 commented Mar 22, 2023

@sschuberth
Copy link
Contributor

sschuberth commented Mar 22, 2023

Thanks @TG1999, so are we good to close this issue? If yes please do so.

bennati added a commit to bennati/python-inspector that referenced this issue Dec 1, 2023
It includes fix for backjumping, see
sarugaku/resolvelib#113

Relates-to: aboutcode-org#106

Signed-off-by: Bennati, Stefano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must have
Projects
None yet
Development

No branches or pull requests

4 participants