Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call function #812

Merged
merged 1 commit into from
Jul 17, 2013
Merged

Call function #812

merged 1 commit into from
Jul 17, 2013

Conversation

chriseppstein
Copy link

This patch lets a function call be invoked where the function itself is provided by a script expression. A special built-in function call is handled by the when the function call is performed and the function is named call.

This implements the functions half of #626.

@Snugug Snugug mentioned this pull request Jun 24, 2013
7 tasks
@nex3
Copy link
Contributor

nex3 commented Jul 1, 2013

Could we try doing this review via Gerrit?

@nex3
Copy link
Contributor

nex3 commented Jul 13, 2013

I was a little weirded out by the special-case handling of call in Funcall, so I tried making it a normal Ruby function and it seems to work. Let me know what you think.

@HamptonMakes
Copy link
Member

+1 on this feature.

@glebm glebm mentioned this pull request Aug 21, 2013
6 tasks
@nex3 nex3 deleted the call_function branch February 21, 2014 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants