Flag-to-track-video-resume-as-CONTENT-START #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timalacey
reviewed
May 30, 2024
| @@ -1427,7 +1438,7 @@ function nrStateTransitionPlaying() as Void | |||
| shouldSendStart = m.nrIsInitialBuffering | |||
| nrSendBufferEnd() | |||
|
|
|||
| if m.nrVideoObject.position = 0 | |||
| if m.nrVideoObject.position = 0 or m.nrShouldTrackResumeAsContentStart | |||
There was a problem hiding this comment.
Suggestion for New Relic folks:
It might be cleaner to remove the position = 0 check. I don't see this check being performed in newrelic-video-core.
There was a problem hiding this comment.
@sathya-sundar have you tried @timalacey's solution? That should fix the issue without the need of introducing the nrShouldTrackResumeAsContentStart flag.
There was a problem hiding this comment.
@sathya-sundar this PR should fix your issue. Could you test it and confirm?
|
We just release a new version (3.2.5) that should fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
Our App has a feature to let user play content from a resume position. We noticed below issue in New Relic reporting when playback initiated using Resume button.
Given: User initiated payback using Resume CTA.
When: videoNode sent to New Relic has videoNode.position > 0
Then: CONTENT_START action not triggered.
Then: Our reports would miss all playbacks initiated through Resume CTA.
Fix:
To fix the above issue, i have added a flag called m.nrShouldTrackResumeAsContentStart, which can be set by the App.
If this flag is set to true, app will trigger CONTENT_START action even if videoNode.position > 0. If will only check if the state changed to
playingafter initial buffer to trigger the CONTENT_START action.