From add6965a7cfd87b28c8d3b6480b855ccd9131aa1 Mon Sep 17 00:00:00 2001 From: hramadan Date: Wed, 16 Aug 2023 08:36:24 -0700 Subject: [PATCH 1/2] Specify method namespace Add full namespace path for method needed to name a Roda transaction --- CHANGELOG.md | 12 ++++++++++-- .../agent/instrumentation/roda/instrumentation.rb | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1a5281d179..c1fd2afc07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,16 @@ # New Relic Ruby Agent Release Notes -## dev +## v9.4.1 -Version of the agent adds [Roda](https://roda.jeremyevans.net/) instrumentation, adds a new `allow_all_headers` configuration option to permit capturing all HTTP headers, introduces improved error tracking functionality by associating a transaction id with each error, and uses more reliable network timeout logic. +Version 9.4.1 of the agent resolves a `NoMethodError` introduced in 9.4.0. + +- **Bugfix: Resolve NoMethodError** + + Ruby agent 9.4.0 introduced [Roda instrumentation](https://github.com/newrelic/newrelic-ruby-agent/pull/2144), which caused a `NoMethodError` to be raised when attempting to name a Roda transaction. This has been fixed. + +## v9.4.0 + +Version 9.4.0 of the agent adds [Roda](https://roda.jeremyevans.net/) instrumentation, adds a new `allow_all_headers` configuration option to permit capturing all HTTP headers, introduces improved error tracking functionality by associating a transaction id with each error, and uses more reliable network timeout logic. - **Feature: Add Roda instrumentation** diff --git a/lib/new_relic/agent/instrumentation/roda/instrumentation.rb b/lib/new_relic/agent/instrumentation/roda/instrumentation.rb index 07adb10236..eee6352c98 100644 --- a/lib/new_relic/agent/instrumentation/roda/instrumentation.rb +++ b/lib/new_relic/agent/instrumentation/roda/instrumentation.rb @@ -41,7 +41,7 @@ def rack_request_params def _roda_handle_main_route_with_tracing(*args) perform_action_with_newrelic_trace( category: :roda, - name: TransactionNamer.transaction_name(request), + name: ::NewRelic::Agent::Instrumentation::Roda::TransactionNamer.transaction_name(request), params: ::NewRelic::Agent::ParameterFiltering::apply_filters(request.env, rack_request_params) ) do yield From bd4b53717c5e672f884c5eaf0e568ada42aa9b21 Mon Sep 17 00:00:00 2001 From: Hannah Ramadan <76922290+hannahramadan@users.noreply.github.com> Date: Wed, 16 Aug 2023 09:14:23 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c1fd2afc07..107ea6dad2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ Version 9.4.1 of the agent resolves a `NoMethodError` introduced in 9.4.0. - **Bugfix: Resolve NoMethodError** - Ruby agent 9.4.0 introduced [Roda instrumentation](https://github.com/newrelic/newrelic-ruby-agent/pull/2144), which caused a `NoMethodError` to be raised when attempting to name a Roda transaction. This has been fixed. + Ruby agent 9.4.0 introduced [Roda instrumentation](https://github.com/newrelic/newrelic-ruby-agent/pull/2144), which caused a `NoMethodError` to be raised when attempting to name a Roda transaction. This has been fixed. Thanks to [@spickermann](https://github.com/spickermann) for reporting this issue. [PR#2167](https://github.com/newrelic/newrelic-ruby-agent/pull/2167) ## v9.4.0