Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core Tech: Rack Gem #791

Closed
4 tasks
angelatan2 opened this issue Sep 23, 2021 · 2 comments · Fixed by #1600
Closed
4 tasks

Update Core Tech: Rack Gem #791

angelatan2 opened this issue Sep 23, 2021 · 2 comments · Fixed by #1600

Comments

@angelatan2
Copy link
Contributor

This is a follow-up story from Ignite Sprint's goal.

  • Understand if methods were deprecated by gem owners.
  • Find new methods that are of value
  • Instrument those new methods
  • Update our multiverse to dynamically pull the latest version so that we do not have to manually update each gem version number manually.
@angelatan2 angelatan2 added the feature request To tag feature request after Hero Triage for PM to disposition label Sep 23, 2021
@kaylareopelle kaylareopelle removed the feature request To tag feature request after Hero Triage for PM to disposition label Aug 16, 2022
@angelatan2 angelatan2 changed the title Update the Rack Gem Update Core Tech: Rack Gem Sep 9, 2022
@workato-integration
Copy link

@fallwith
Copy link
Contributor

fallwith commented Nov 8, 2022

Understand if methods were deprecated by gem owners.

We instrument URLMap and Builder. Neither of these have been deprecated. Builder#run has been updated to accept a block, however, and we will need to conditionally (if Rack >= v3.0.0) update our own instrumentation to handle a block as well.

Find new methods that are of value

and

Instrument those new methods

From looking over the added list, there isn't anything new on the same level as Builder or URLMap.

Update our multiverse to dynamically pull the latest version so that we do not have to manually update each gem version number manually.

This has already been done for Rack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants