Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method, NewRelic::Agent#disable_transaction_tracing #745

Closed
kaylareopelle opened this issue Aug 2, 2021 · 4 comments
Closed

Remove deprecated method, NewRelic::Agent#disable_transaction_tracing #745

kaylareopelle opened this issue Aug 2, 2021 · 4 comments
Assignees
@hannahramadan
Labels
documentation version: 9.0.0 Major Release - Breaking Changes
Milestone
Major Release 9.0

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Aug 2, 2021 •
edited by angelatan2
Loading

The NewRelic::Agent#disable_transaction_tracing method was deprecated three years ago. Let's remove it.

File: lib/new_relic/agent.rb

  • Remove the deprecated method, NewRelic::Agent#disable_transaction_tracing
  • Replace all calls to NewRelic::Agent#disable_transaction_tracing with NewRelic::Agent#disable_all_tracing or NewRelic::Agent#ignore_transaction
  • Add removal to CHANGELOG
  • This is part of the public API. Update references in the documentation to note removal, replacements, and supported versions.
  • Add steps to adjust to the migration guide
@kaylareopelle kaylareopelle changed the title Remove NewRelic::Agent#disable_transaction_tracing Remove deprecated method, NewRelic::Agent#disable_transaction_tracing Aug 2, 2021
@angelatan2
Copy link
Contributor

Size = S

@angelatan2
Copy link
Contributor

For the initial scope, let's review and see if the public API doc has called out deprecation in addition to the deprecation shown in the log for this method.

@angelatan2 angelatan2 added version: 9.0.0 Major Release - Breaking Changes and removed version:upcoming labels Mar 4, 2022
@angelatan2 angelatan2 added this to the Major Release 9.0 milestone Mar 25, 2022
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-6455

@hannahramadan hannahramadan self-assigned this Feb 3, 2023
@hannahramadan hannahramadan mentioned this issue Feb 4, 2023
Merged
@tannalynn
Copy link
Contributor

closing, PR merged

@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannahramadan hannahramadan

Labels
documentation version: 9.0.0 Major Release - Breaking Changes
Projects
Ruby Engineering Board
Archived in project
Milestone
Major Release 9.0
Development

No branches or pull requests
4 participants
@tannalynn @angelatan2 @hannahramadan @kaylareopelle