Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Logstasher #2399

Closed
kford-newrelic opened this issue Jan 18, 2024 · 3 comments · Fixed by #2559
Closed

Add support for Logstasher #2399

kford-newrelic opened this issue Jan 18, 2024 · 3 comments · Fixed by #2559
Assignees
Labels
5 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter feature request To tag feature request after Hero Triage for PM to disposition GTSE Issue associated with a previously logged support escalation

Comments

@kford-newrelic
Copy link

kford-newrelic commented Jan 18, 2024

Is your feature request related to a problem? Please describe.

From the support issue:

  • "Logstasher functions in a way that is not compatible with the way the agent instruments the Ruby Logger class."
  • "Currently the log decorator isn't compatible with json logs, so that would also need to be implemented."

Feature Description

Add ability to automatically instrument and forward Logstasher logs. Additionally, add local log decoration.

Describe Alternatives

N/A

Additional context

Original FR - NR-169467

Priority

Really Want

@kford-newrelic kford-newrelic added the feature request To tag feature request after Hero Triage for PM to disposition label Jan 18, 2024
@workato-integration
Copy link

@kford-newrelic kford-newrelic added the GTSE Issue associated with a previously logged support escalation label Jan 18, 2024
@kaylareopelle
Copy link
Contributor

Relates to #2341, since they both have the JSON-style logs. The agent spec on JSON log formatted logs must be merged before we can work on this.

@kford-newrelic kford-newrelic added estimate Issue needing estimation apr-jun qtr Represents proposed work item for the Apr-Jun quarter labels Feb 8, 2024
@fallwith
Copy link
Contributor

As @kaylareopelle mentions above in reference to #2341, there are 2 key aspects to this issue:

  • Supporting JSON formatted log data
  • Supporting the Logstasher gem's functions

When we work on this one, let's be sure that the JSON handling side of things is implemented generically for re-use by Semantic Logger and other JSON based logger libraries, whether that means code reuse with modules or some other DRY approach.

@kford-newrelic kford-newrelic added 5 Story Point Estimate and removed estimate Issue needing estimation labels Feb 16, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Apr 1, 2024
@hannahramadan hannahramadan moved this from In Quarter to In Sprint in Ruby Engineering Board Apr 10, 2024
@hannahramadan hannahramadan self-assigned this Apr 10, 2024
@hannahramadan hannahramadan moved this from In Sprint to In Quarter in Ruby Engineering Board Apr 15, 2024
@hannahramadan hannahramadan moved this from In Quarter to In Sprint in Ruby Engineering Board Jun 11, 2024
@github-project-automation github-project-automation bot moved this from In Sprint to Code Complete/Done in Ruby Engineering Board Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter feature request To tag feature request after Hero Triage for PM to disposition GTSE Issue associated with a previously logged support escalation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants