Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to add custom attributes to logs based on context #2297

Open
kaylareopelle opened this issue Oct 27, 2023 · 8 comments
Open

API to add custom attributes to logs based on context #2297

kaylareopelle opened this issue Oct 27, 2023 · 8 comments
Labels
5 Story Point Estimate community To tag external issues and PRs submitted by the community feature request To tag feature request after Hero Triage for PM to disposition oct-dec qtr Possible FY Q3 candidate

Comments

@kaylareopelle
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I was hoping to append metadata to the individual log entries to make it a lot easier for us to track usage, without having to resort to adding data to the log messages themselves or changing formatters, and parse with grok to pull out the data. Some of the log entries also pass the size limits of New Relic, so it makes using the grok approach a little less consistent, depending on what's coming in.

As an example: We're wanting to attach user_id metadata to the log entries, as well as authentication entry points that the user went through. (login, token, oauth) -- That allows is to isolate traffic better to see trends on usage by our customers, by the approach they're using.

Feature Description

Create a new API that allows custom log attributes to be attached to log entries based on the current context.

Describe Alternatives

A clear and concise description of any alternative solutions or features you've considered. Are there examples you could link us to?
TBD

Priority

Please help us better understand this feature request by choosing a priority from the following options:
[Nice to Have, Really Want, Must Have, Blocker]

@kaylareopelle kaylareopelle added the feature request To tag feature request after Hero Triage for PM to disposition label Oct 27, 2023
@workato-integration
Copy link

@dinsley
Copy link
Contributor

dinsley commented Oct 27, 2023

I'd be happy to take a crack at this one if it's something the team feels would have a chance to be merged. If so, If anyone on the project has knowledge of any high-level gotchas to watch out for when doing this it would be much appreciated!

We were looking at exploring how to solve for this other ways to get the data in there, but I'd much rather spend the time doing it here, where other people could take advantage as well.

@kaylareopelle
Copy link
Contributor Author

Excellent! I'll bring this up with the team during our planning session on Monday to see if we want to move forward with this FR. I'll get back to you soon!

No gotchas come to mind at this time, but I'll think this over and update the issue if I think of any.

The PR for the global custom log attribute API might be helpful: #2084

@kaylareopelle kaylareopelle added the community To tag external issues and PRs submitted by the community label Oct 28, 2023
@dinsley
Copy link
Contributor

dinsley commented Oct 31, 2023

Thanks! Did you happen to get a chance to discuss with the team in the planning session on this? We're hitting some issues where getting the metadata on there would be incredibly useful to pinpoint where it's originating from, so we can get some time for team member(s) in our org to get this done :)

No worries if not, we can look at alternative approaches in the platform to try and get that visibility.

@kaylareopelle
Copy link
Contributor Author

Hi @dinsley, sorry for the delay, I was out sick. We talked about it as a team and would love to have this feature implemented, especially by you/your team as the reporters of the FR! 😄

We'll do everything we can to help you and your team get the PR merged. Please let us know if you have any questions or run into any roadblocks.

@kford-newrelic kford-newrelic added estimate Issue needing estimation jan-mar qtr Possible FY Q4 candidate labels Nov 20, 2023
@kford-newrelic kford-newrelic removed the jan-mar qtr Possible FY Q4 candidate label Dec 20, 2023
@kford-newrelic kford-newrelic added the apr-jun qtr Represents proposed work item for the Apr-Jun quarter label Feb 8, 2024
@kford-newrelic kford-newrelic added 5 Story Point Estimate jul-sep qtr Represents proposed work item for the Jul-Sep quarter and removed estimate Issue needing estimation apr-jun qtr Represents proposed work item for the Apr-Jun quarter labels Mar 6, 2024
@kford-newrelic kford-newrelic removed the jul-sep qtr Represents proposed work item for the Jul-Sep quarter label May 23, 2024
@kaylareopelle kaylareopelle added the oct-dec qtr Possible FY Q3 candidate label May 23, 2024
@mzagaja
Copy link

mzagaja commented Sep 23, 2024

Just adding my support for this feature here as someone looking into semantic logger and finding the present need/practice of nesting things under message key to be a bit counter-intuitive.

@kaylareopelle
Copy link
Contributor Author

Thanks, @mzagaja! This is helpful context!

@fabn
Copy link

fabn commented Oct 2, 2024

This would be great 👍 (SemanticLogger user ✋ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Point Estimate community To tag external issues and PRs submitted by the community feature request To tag feature request after Hero Triage for PM to disposition oct-dec qtr Possible FY Q3 candidate
Projects
Development

No branches or pull requests

6 participants