Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: ensure the container id can be gleaned #2026

Closed
fallwith opened this issue May 23, 2023 · 2 comments · Fixed by #2229
Closed

Docker: ensure the container id can be gleaned #2026

fallwith opened this issue May 23, 2023 · 2 comments · Fixed by #2229
Assignees
@fallwith
Labels
1 Story Point Estimate

Comments

@fallwith
Copy link
Contributor

With chatter picking up about alternatives to using cgroups to obtain a Docker container's id, we should track with internal and external best practices to make sure we're able to glean a container's id in as many contexts as possible.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-8772

@workato-integration workato-integration bot changed the title Docker: ensure the container id can be gleaned Docker: ensure the container id can be gleaned May 23, 2023
@fallwith fallwith added oct-dec qtr Possible FY Q3 candidate estimate Issue needing estimation labels Sep 12, 2023
@fallwith
Copy link
Contributor Author

We've agreed to target cgroups v1 and v2 compatibility. See cross agent specs PR 635 for details.

@kford-newrelic kford-newrelic removed estimate Issue needing estimation oct-dec qtr Possible FY Q3 candidate labels Sep 14, 2023
@fallwith fallwith added the 1 Story Point Estimate label Sep 15, 2023
@kford-newrelic kford-newrelic added the oct-dec qtr Possible FY Q3 candidate label Sep 18, 2023
@fallwith fallwith removed the oct-dec qtr Possible FY Q3 candidate label Sep 20, 2023
@fallwith fallwith self-assigned this Sep 20, 2023
@fallwith fallwith moved this from Triage to In progress in Ruby Engineering Board Sep 20, 2023
@fallwith fallwith mentioned this issue Sep 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from In progress to Code Complete/Done in Ruby Engineering Board Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallwith fallwith

Labels
1 Story Point Estimate
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support cgroups v1 and v2 for Docker containers newrelic/newrelic-ruby-agent
2 participants
@fallwith @kford-newrelic