Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failure on railsedge #1775

Closed
tannalynn opened this issue Jan 27, 2023 · 2 comments
Closed

Test Failure on railsedge #1775

tannalynn opened this issue Jan 27, 2023 · 2 comments

Comments

@tannalynn
Copy link
Contributor

We test railsedge in our nightly CI, but after recent commits to rails, this test is failing:

Failure:
NewRelic::Agent::Instrumentation::ActionControllerSubscriberTest#test_records_filtered_request_params_in_txn [/Users/tmcclure/projects/ruby-agent/test/new_relic/agent/instrumentation/rails/action_controller_subscriber.rb:306]:
Expected: "[FILTERED]"
  Actual: "secret"

The cause of this failure seems to be that our block we give to Rails.application.config.to_prepare in lib/new_relic/agent/parameter_filtering.rb is not getting called for some reason.

This is the commit where the issue first starts: rails/rails@896c7fa in gemfile:

 gem 'rails', git: 'https://github.com/rails/rails.git', ref: '896c7faedf01893c50d963aa4f7857b42373bd03'

The commit before that has everything passing rails/rails@f6e36c9

Checking the Gemfile.lock, when it passes it is using rack 2.2.6.2, and when it fails it's using rack 3.0.4.1. It's not clear to me at this point why a change in rack version would prevent our Rails.application.config.to_prepare block in lib/new_relic/agent/parameter_filtering.rb from getting called.

@workato-integration
Copy link

@fallwith
Copy link
Contributor

Addressed by the Ruby community. Rails EDGE testing resumed on a nightly basis with #1898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants