Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis gem instrumentation: add better error handling around v5+ specific instrumentation #1671

Closed
fallwith opened this issue Dec 2, 2022 · 1 comment · Fixed by #1673
Closed

Comments

@fallwith
Copy link
Contributor

fallwith commented Dec 2, 2022

v8.13.0 of the agent introduced support for v5 of the redis gem, and v8.13.1 followed to address a Sidekiq v7 specific use case.

Now with v8.13.1, we have had reports of additional issues that the agent has when attempting to get at the lowest underlying Redis client object within the redis v5 instrumentation.

While we continue to research these reports and attempt to produce reproductions, in parallel or beforehand we should take steps to harden the impacted redis v5 instrumentation to prevent it from crashing. From the customer's perspective, any issue encountered with the Redis v5 instrumentation should result in either parial or no Redis instrumentation with the rest of the agent's functionality continuing to operate normally. Effectively, the error handling should automatically provide at least as good of an experience as rolling back to an agent version that does not have the v5 instrumentation or disabling the instrumentation support in configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant