Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument and test Concurrent::ScheduledTask#execute #1645

Closed
kaylareopelle opened this issue Nov 18, 2022 · 4 comments
Closed

Instrument and test Concurrent::ScheduledTask#execute #1645

kaylareopelle opened this issue Nov 18, 2022 · 4 comments

Comments

@kaylareopelle
Copy link
Contributor

Acceptance Criteria

  • Add a segment to the existing transaction or create a new transaction when Concurrent::ScheduledTask#execute is called
    • If the method starts a transaction, it should have a non-web type
    • This is different from the others because it’s more likely to take place outside of a transaction-creating library call

Resources

@workato-integration
Copy link

@kaylareopelle
Copy link
Contributor Author

Blocked by #1602

@kaylareopelle
Copy link
Contributor Author

#1602 is complete! All clear. Please branch off concurrent_ruby

@kaylareopelle
Copy link
Contributor Author

#1601 covers Concurrent::ScheduledTask#execute because RubyExecutorService#post is invoked by Concurrent::ScheduledTask#execute. We don't need special instrumentation for this method if we instrument RubyExecutorService#post.

@hannahramadan - We should still add this method to our playground applications to run thorough tests on this method.

@kaylareopelle kaylareopelle closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant