Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails notifications: subscribe to ActiveJob topics #1515

Closed
fallwith opened this issue Oct 1, 2022 · 2 comments · Fixed by #1761
Closed

Rails notifications: subscribe to ActiveJob topics #1515

fallwith opened this issue Oct 1, 2022 · 2 comments · Fixed by #1761
Assignees
@fallwith
Labels
rails Issues related to the Ruby on Rails framework
Milestone
Improve Rails Ins...

Comments

@fallwith
Copy link
Contributor

fallwith commented Oct 1, 2022 •
edited by kaylareopelle
Loading

Rails will publish content to the following 4 ActiveJob topics:

  • enqueue_at.active_job
  • enqueue.active_job
  • enqueue_retry.active_job
  • perform.active_job

We should subscribe to these in a similar manner used for *.action_controller and *.action_view topics.

NOTE: we currently instrument ActiveJob without taking advantage of subscriptions. Make sure to not collide / overlap with that existing instrumentation.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-4140

@fallwith fallwith added this to the Rails Notifications milestone Oct 1, 2022
@fallwith fallwith mentioned this issue Oct 1, 2022
Closed
@kaylareopelle kaylareopelle added rails Issues related to the Ruby on Rails framework and removed core technology labels Oct 28, 2022
@fallwith fallwith changed the title Rails notifications: subscribe to ActiveJob topics Rails notifications: subscribe to additional ActiveJob topics Nov 8, 2022
@fallwith fallwith changed the title Rails notifications: subscribe to additional ActiveJob topics Rails notifications: subscribe to ActiveJob topics Nov 8, 2022
@fallwith fallwith self-assigned this Jan 20, 2023
@fallwith
Copy link
Contributor Author

The latest Active Support instrumentation guide references these additional 3 events:

  • perform_start.active_job
  • retry_stopped.active_job
  • discard.active_job

@fallwith fallwith mentioned this issue Jan 25, 2023
Merged
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallwith fallwith

Labels
rails Issues related to the Ruby on Rails framework
Projects
Ruby Engineering Board
Archived in project
Milestone
Improve Rails Instrumentation
Development

Successfully merging a pull request may close this issue.

Active Job notifications subscriber newrelic/newrelic-ruby-agent
2 participants
@fallwith @kaylareopelle