Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails notifications: subscribe to additional ActionView topics #1512

Closed
fallwith opened this issue Oct 1, 2022 · 1 comment · Fixed by #1748 or #1744
Closed

Rails notifications: subscribe to additional ActionView topics #1512

fallwith opened this issue Oct 1, 2022 · 1 comment · Fixed by #1748 or #1744
Assignees
@hannahramadan
Labels
rails Issues related to the Ruby on Rails framework
Milestone
Improve Rails Ins...

Comments

@fallwith
Copy link
Contributor

fallwith commented Oct 1, 2022

Via lib/new_relic/agent/instrumentation/action_view_subscriber.rb, we currently subscribe to 3 ActionView topics. These topics are stored as constants RENDER_TEMPLATE_EVENT_NAME, RENDER_PARTIAL_EVENT_NAME, and RENDER_COLLECTION_EVENT_NAME in that class.

Rails will publish to another topic, render_layout.action_view. We should subscribe to this one as well.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-4137

@fallwith fallwith added this to the Rails Notifications milestone Oct 1, 2022
@fallwith fallwith mentioned this issue Oct 1, 2022
Closed
@kaylareopelle kaylareopelle added rails Issues related to the Ruby on Rails framework and removed core technology hacktoberfest labels Oct 28, 2022
@hannahramadan hannahramadan self-assigned this Dec 30, 2022
@hannahramadan hannahramadan added the in progress In progress or waiting for more information label Jan 6, 2023
@hannahramadan hannahramadan removed in progress In progress or waiting for more information help wanted labels Jan 6, 2023
@hannahramadan hannahramadan mentioned this issue Jan 20, 2023
Merged
@tannalynn tannalynn mentioned this issue Jan 24, 2023
Merged
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannahramadan hannahramadan

Labels
rails Issues related to the Ruby on Rails framework
Projects
Ruby Engineering Board
Archived in project
Milestone
Improve Rails Instrumentation
3 participants
@fallwith @hannahramadan @kaylareopelle