Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails notifications: subscribe to additional ActionController topics #1510

Closed
fallwith opened this issue Sep 30, 2022 · 1 comment · Fixed by #1744
Closed

Rails notifications: subscribe to additional ActionController topics #1510

fallwith opened this issue Sep 30, 2022 · 1 comment · Fixed by #1744
Assignees
@tannalynn
Labels
rails Issues related to the Ruby on Rails framework
Milestone
Improve Rails Ins...

Comments

@fallwith
Copy link
Contributor

fallwith commented Sep 30, 2022 •
edited by hannahramadan
Loading

We currently subscribe to a single ActionController related topic, process_action.action_controller via lib/new_relic/agent/instrumentation/rails_notifications/action_controller.rb. We should be subscribing to these others as well:

  • start_processing.action_controller
  • send_file.action_controller
  • send_data.action_controller
  • redirect_to.action_controller
  • halted_callback.action_controller
  • unpermitted_parameters.action_controller

Our subscription method is regex based, so we could potentially use /\.action_controller$/.

So the regex here would simply be altered so that it could match the existing process_action.action_controller topic AND all of the other topic listed above.

Resources:
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-4134

@fallwith fallwith added this to the Rails Notifications milestone Oct 1, 2022
@fallwith fallwith mentioned this issue Oct 1, 2022
Closed
@kaylareopelle kaylareopelle added rails Issues related to the Ruby on Rails framework and removed core technology hacktoberfest labels Oct 28, 2022
@hannahramadan hannahramadan mentioned this issue Nov 23, 2022
Closed
4 tasks
@tannalynn tannalynn mentioned this issue Jan 20, 2023
Merged
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannalynn tannalynn

Labels
rails Issues related to the Ruby on Rails framework
Projects
Ruby Engineering Board
Archived in project
Milestone
Improve Rails Instrumentation
Development

Successfully merging a pull request may close this issue.

Subscribe to additional Action controller topics newrelic/newrelic-ruby-agent
3 participants
@fallwith @tannalynn @kaylareopelle