Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate and resolve rubocop-minitest errors #1403

Closed
14 tasks done
hannahramadan opened this issue Sep 9, 2022 · 2 comments
Closed
14 tasks done

Evaluate and resolve rubocop-minitest errors #1403

hannahramadan opened this issue Sep 9, 2022 · 2 comments
Assignees
@hannahramadan
Labels
technical debt

Comments

@hannahramadan
Copy link
Contributor

hannahramadan commented Sep 9, 2022 •
edited
Loading

Description

Currently, failing rubocop-minitest cops are disabled by .rubocop_todo.yml. These include:

Evaluate each of these cops and decide whether they should remain disabled or if the error should be addressed. If it's decided the error should be addressed, resolve it in the code.

Estimates

S = 1-3 days
@kaylareopelle kaylareopelle changed the title Evaluate and resolve rubocop-minitest errors Quality: Evaluate and resolve rubocop-minitest errors Sep 9, 2022
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-3378

@workato-integration workato-integration bot changed the title Quality: Evaluate and resolve rubocop-minitest errors Evaluate and resolve rubocop-minitest errors Sep 12, 2022
This was referenced Sep 12, 2022
Merged
Merged
@hannahramadan hannahramadan self-assigned this Sep 29, 2022
@kaylareopelle
Copy link
Contributor

It looks like this is finished! I'm going to close this out.

@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannahramadan hannahramadan

Labels
technical debt
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannahramadan @kaylareopelle