Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Investigate test failure when using rack-test 2.0.0 #1222

Closed
tannalynn opened this issue Jun 24, 2022 · 1 comment · Fixed by #1591
Closed

CI: Investigate test failure when using rack-test 2.0.0 #1222

tannalynn opened this issue Jun 24, 2022 · 1 comment · Fixed by #1591
Assignees
@hannahramadan
Labels
core technology technical debt
Milestone
FY23Q3 Core Techn...

Comments

@tannalynn
Copy link
Contributor

tannalynn commented Jun 24, 2022 •
edited by hannahramadan
Loading

Description

We use rack-test in a lot of our test suites. Recently rack-test 2.0.0 was released, which caused one test in multiverse[rails] to consistently fail across all ruby and rails versions that use this version of rack-test. All other tests appear to be working as expected when using rack-test 2.0.0. For now, we are pinning rack-test < 2.0 to avoid this blocking our CI runs.

Failure:
ActionControllerLiveRumTest#test_excludes_rum_instrumentation_when_streaming_with_action_stream_true [/Users/tmcclure/projects/ruby-agent/test/multiverse/suites/rails/action_controller_live_rum_test.rb:45]:
Expected "<html><head>\n<script type=\"text/javascript\">window.NREUM||(NREUM={});NREUM.info={\"beacon\":\"beacon\",\"errorBeacon\":\"\",\"licenseKey\":\"key\",\"applicationID\":\"\",\"transactionName\":\"IQteEUMLWV4EFk4RCwYBUQEeBkdTCAo+FxEQAVEI\",\"queueTime\":0,\"applicationTime\":18,\"agent\":\"\"}</script>\n<script type=\"text/javascript\">JS LOADER IN DA HOUSE</script></head><body>Brains!</body></html>" 
to include "<html><head></head><body>Brains!</body></html>".
@kaylareopelle kaylareopelle added this to the Multiverse Updates milestone Jul 29, 2022
@fallwith fallwith changed the title Investigate test failure when using rack-test 2.0.0 CI: Investigate test failure when using rack-test 2.0.0 Aug 16, 2022
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-3437

@workato-integration workato-integration bot changed the title CI: Investigate test failure when using rack-test 2.0.0 CI: Investigate test failure when using rack-test 2.0.0 Sep 12, 2022
@hannahramadan hannahramadan self-assigned this Nov 2, 2022
@hannahramadan hannahramadan mentioned this issue Nov 4, 2022
Merged
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannahramadan hannahramadan

Labels
core technology technical debt
Projects
Ruby Engineering Board
Archived in project
Milestone
FY23Q3 Core Technologies
Development

Successfully merging a pull request may close this issue.

NR-1222/rack-test-v2 newrelic/newrelic-ruby-agent
5 participants
@fallwith @tannalynn @angelatan2 @hannahramadan @kaylareopelle