Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes configs default values #1091

Closed
kaylareopelle opened this issue Apr 15, 2022 · 3 comments
Closed

Update attributes configs default values #1091

kaylareopelle opened this issue Apr 15, 2022 · 3 comments

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Apr 15, 2022

The Ruby Agent is not yet in compliance with the default attributes.include and attributes.exclude values outlined in the Agent Attributes PORTED: Request Headers spec (Internal).

It also seems like we need to add an allow_all_headers to meet the full spec requirements.

Original discussion (Internal)

T-Shirt size

@workato-integration
Copy link

@fallwith
Copy link
Contributor

fallwith commented Jun 5, 2023

The "all headers" part may be related to #1029

@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Sep 14, 2023
@kford-newrelic kford-newrelic removed the estimate Issue needing estimation label Sep 25, 2023
@fallwith
Copy link
Contributor

The allow_all_headers functionality went in with #2155.

For the include and exclude lists, there has been .NET agent work recently to specifically implement new excludes for use with request headers. But given that these lists are used for more than just request headers and given the non-request-header-specific agent specs that do indeed call for empty lists as we have now, we're hesitant to make any changes at this time that could impact existing customers unexpectedly.

As customer requests and large scale specs vs. implementation audits continue, we can revisit later - possibly with a major agent version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants