Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_transaction_name does not apply :task as a category #1064

Closed
kaylareopelle opened this issue Apr 8, 2022 · 3 comments
Closed

set_transaction_name does not apply :task as a category #1064

kaylareopelle opened this issue Apr 8, 2022 · 3 comments
Assignees
Labels
GTS GTS type of issue version: 9.0.0 Major Release - Breaking Changes

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Apr 8, 2022

Description

The public API method set_transaction_name allows the user to optionally pass in a :category argument with the values of either :controller, :task, :middleware, or :uri. These values map to overarching categories for transactions.

We have a customer who tried to use this method with the :task category, but did not have their transactions successfully assigned as Non-Web/Background tasks.

A refactor to the method NewRelic::Agent::Transaction#set_overriding_transaction_name made it so it would not be possible for any transaction pre-categorized as a web transaction to be overridden to be a non-web transaction.

Expected Behavior

Users of the public API should be able to pass in the category: :task argument to set_transaction_name and have the transaction be re-categorized as a Non-Web or Background transaction. This change should not re-categorize the parent transaction (if there is one).

Internal Reference: GTSE-14114

T-Shirt size

@angelatan2 angelatan2 added the GTS GTS type of issue label Apr 8, 2022
@kaylareopelle kaylareopelle added the version: 9.0.0 Major Release - Breaking Changes label May 25, 2022
@kaylareopelle
Copy link
Contributor Author

After running some tests, this behavior is inherently different from how the agent currently behaves, even though the agent is not behaving in the documented way. Due to the number of broken tests to implement this fix, I think this needs to be included as part of our next major version release.

@fallwith fallwith added the P4-Bug Priority 4 Bug label Aug 30, 2022
@angelatan2 angelatan2 removed bug P4-Bug Priority 4 Bug labels Sep 9, 2022
@workato-integration
Copy link

@kaylareopelle
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @fallwith @hannahramadan @tannalynn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTS GTS type of issue version: 9.0.0 Major Release - Breaking Changes
Projects
Archived in project
Development

No branches or pull requests

4 participants