Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT headers added too late for Feign #249

Closed
jodeev opened this issue Mar 20, 2021 · 4 comments
Closed

DT headers added too late for Feign #249

jodeev opened this issue Mar 20, 2021 · 4 comments
Labels
bug Something isn't working as designed/intended wontfix Issue will not be worked on

Comments

@jodeev
Copy link
Contributor

jodeev commented Mar 20, 2021

Feign (from Spring Cloud Finchley.SR1) appears to be altering the codepath a generated request takes and causes our auto-injection of DT headers to fail.

Description:

  • The application uses Spring Boot (version 2.1.10.RELEASE) and Feign (from Spring Cloud Finchley.SR1).
  • When using a rest client, generated by Feign, New Relic agent is adding headers too late: it comes to sun.net.www.protocol.http.HttpURLConnection#addRequestProperty and fails to add any headers with IllegalStateException("Already connected").
  • With Spring's RestTemplate the headers are added correctly.

Test app showing this issue included here:
https://newrelic.zendesk.com/agent/tickets/442571

https://newrelic.aha.io/ideas/ideas/JAVA-I-1001

@jodeev jodeev added the bug Something isn't working as designed/intended label Mar 20, 2021
@gustavodaquino
Copy link

gustavodaquino commented Aug 4, 2022

The problem persists using the following versions:

org.springframework.boot:2.6.10
com.newrelic.agent.java:newrelic-api:7.6.0
org.springframework.cloud:spring-cloud-starter-openfeign:3.1.3
io.github.openfeign:feign-httpclient:11.8

Regards.

@kford-newrelic
Copy link
Contributor

@gustavodaquino any chance you have a sample app that reproduces the problem that you can share with us?

@kford-newrelic kford-newrelic added the wontfix Issue will not be worked on label Sep 8, 2022
@kford-newrelic
Copy link
Contributor

Unfortunately, we do not have the engineering bandwidth to further investigate this issue.

@kford-newrelic kford-newrelic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
@jasonjkeller
Copy link
Contributor

I believe this issue should actually be fixed in Java agent 8.0.1 by #1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as designed/intended wontfix Issue will not be worked on
Projects
Archived in project
Development

No branches or pull requests

4 participants