Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support external calls inside Spring Reactor call chains #1800

Closed
jbedell-newrelic opened this issue Mar 14, 2024 · 2 comments · Fixed by #1828
Closed

Support external calls inside Spring Reactor call chains #1800

jbedell-newrelic opened this issue Mar 14, 2024 · 2 comments · Fixed by #1828
Assignees
@jbedell-newrelic
Labels
5 Story Point Estimate

Comments

@jbedell-newrelic
Copy link
Contributor

jbedell-newrelic commented Mar 14, 2024 •
edited
Loading

Result of #1780

The issue is definitely a missed thread hop. A simple repro app can be created to reproduce the issue. Something along the lines of:
client.callExternal1().flatMapMany(this::callExternal2).collectList().block();

In this example the external call to External1 will show up in the trace, but the call to External2 will not.

On investigation, the tokenLift() method is not being executed in this scenario, nor is the Hooks.onEachOperator being called.
@jbedell-newrelic jbedell-newrelic added the feature request Suggestion for a new product enhancement or change label Mar 14, 2024
@jbedell-newrelic jbedell-newrelic self-assigned this Mar 14, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-249061

@jbedell-newrelic jbedell-newrelic mentioned this issue Mar 14, 2024
Closed
@jbedell-newrelic jbedell-newrelic added 5 Story Point Estimate and removed feature request Suggestion for a new product enhancement or change labels Mar 14, 2024
@jbedell-newrelic jbedell-newrelic mentioned this issue Mar 29, 2024
Merged
@jbedell-newrelic
Copy link
Contributor Author

Resolved by: #1828

@jbedell-newrelic jbedell-newrelic linked a pull request Mar 29, 2024 that will close this issue
1780 spring reactor chaining #1828
Merged
@jbedell-newrelic jbedell-newrelic moved this from In Sprint to Needs Review in Java Engineering Board Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedell-newrelic jbedell-newrelic

Labels
5 Story Point Estimate
Projects
Java Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1780 spring reactor chaining newrelic/newrelic-java-agent
1 participant
@jbedell-newrelic