Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain Servlet isn't sending user data for code.namespace #1394

Closed
kford-newrelic opened this issue Jul 14, 2023 · 2 comments
Closed

Plain Servlet isn't sending user data for code.namespace #1394

kford-newrelic opened this issue Jul 14, 2023 · 2 comments
Assignees

Comments

@kford-newrelic
Copy link
Contributor

The Span data collected for an app that only uses Servlet and no other web framework is collecting library data in its code.namespace value.

since this query could age out, i'll add a screenshot of its results below. 

With this Span data below, you can see that the Span name is more accurately describing user code, and the code.namespace property appears to be library code. 

I'm not a java expert, and can't say if it's possible, but in this use case, i believe the user's expectation is that code.namespace would be "com.example.javaeehelloworld.HelloServlet" and "service" would map to onGet (if that's even possible). this would allow CodeStream to show a code lens for it in the IDE. there's a screenshot of the user's code file attached here too.

"code.function": "service",
"code.namespace": "jakarta.servlet.http.HttpServlet",
"entity.name": "Glassfish A",
"entityGuid": "MjA0Njg5N3xBUE18QVBQTElDQVRJT058MTA3NTAwNjkwNg",   
"name": "Servlet/com.example.javaeehelloworld.HelloServlet/service",

slack thread: https://newrelic.slack.com/archives/C025T6V8R5X/p1671567123137479

@workato-integration
Copy link

@kford-newrelic kford-newrelic moved this from Triage to In progress in Java Engineering Board Jul 14, 2023
@deleonenriqueta
Copy link
Contributor

deleonenriqueta commented Jul 31, 2023

@deleonenriqueta deleonenriqueta moved this from In progress to Done in Java Engineering Board Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants