Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring 6 (Boot3) does not report underlying exception/stacktrace when a @RestControllerAdvice class is used #1393

Closed
jtduffy opened this issue Jul 14, 2023 · 4 comments · Fixed by #1538
Closed

Spring 6 (Boot3) does not report underlying exception/stacktrace when a @RestControllerAdvice class is used #1393

jtduffy opened this issue Jul 14, 2023 · 4 comments · Fixed by #1538
Labels
3 Story Point Estimate GTSE There is an associated support escalation with this issue. oct-dec qtr Represents proposed work item for the Oct-Dec quarter
Milestone
Java Agent FY24Q3...

Comments

@jtduffy
Copy link
Contributor

jtduffy commented Jul 14, 2023 •
edited
Loading

With Spring 5 (Boot v2), NR instrumentation reports the underlying exception when utilizing a @RestControllerAdvice class. In Spring v6 (Boot v3) the underlying exception is not reported.

Goals:

  • Verify the exception behavior with Spring 5 and Spring 6
    • Reported exception behavior with @RestControllerAdvice
    • Reported exception behavior without @RestControllerAdvice
  • Investigate and document underlying cause
  • Implement a fix or open an additional ticket if the fix is a heavy lift

UI Screenshot showing exception for Spring v5

Springv5ShowingException

UI Screenshot showing examples with and without RestControllerAdvice

RestControllerAdviceUI

Example repro code

SampleSourceCode
@jtduffy jtduffy added the bug Something isn't working as designed/intended label Jul 14, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-142245

@kford-newrelic kford-newrelic added estimate Issue needing estimation and removed bug Something isn't working as designed/intended labels Jul 14, 2023
@kford-newrelic kford-newrelic added 3 Story Point Estimate oct-dec qtr Represents proposed work item for the Oct-Dec quarter estimate Issue needing estimation and removed estimate Issue needing estimation oct-dec qtr Represents proposed work item for the Oct-Dec quarter labels Jul 20, 2023
@kford-newrelic kford-newrelic added the oct-dec qtr Represents proposed work item for the Oct-Dec quarter label Aug 10, 2023
@kford-newrelic kford-newrelic added the GTSE There is an associated support escalation with this issue. label Aug 21, 2023
@shashikantfayke
Copy link

Any update on this issue ? Recently we are also migrated to spring boot3 with newrelic java agent 8.5.0 and we are facing the same issue as well

@kford-newrelic
Copy link
Contributor

@shashikantfayke not at the moment - we are planning to investigate further in the coming oct-dec quarter

@gustavodaquino
Copy link

I'm facing the same problem since we migrated our applications to SB 3.x due compliance reasons.

@kford-newrelic kford-newrelic moved this from Triage to To do in Java Engineering Board Oct 2, 2023
@jtduffy jtduffy mentioned this issue Oct 5, 2023
Merged
@jtduffy jtduffy moved this from To do to In progress in Java Engineering Board Oct 5, 2023
@jtduffy jtduffy moved this from In progress to Needs Review in Java Engineering Board Oct 5, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 Story Point Estimate GTSE There is an associated support escalation with this issue. oct-dec qtr Represents proposed work item for the Oct-Dec quarter
Projects
Java Engineering Board
Archived in project
Milestone
Java Agent FY24Q3 Enhancements
4 participants
@jtduffy @gustavodaquino @shashikantfayke @kford-newrelic