Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External HTTP requests missing /External/{host}/all rollup metric #1091

Closed
kford-newrelic opened this issue Nov 28, 2022 · 3 comments · Fixed by #1102
Closed

External HTTP requests missing /External/{host}/all rollup metric #1091

kford-newrelic opened this issue Nov 28, 2022 · 3 comments · Fixed by #1102
Assignees
@jasonjkeller
Labels
GTSE There is an associated support escalation with this issue. on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter

Comments

@kford-newrelic
Copy link
Contributor

kford-newrelic commented Nov 28, 2022 •
edited by jasonjkeller
Loading

Description

Customer upgraded from Weblogic 10 to Weblogic 12, while also upgrading their agent from 3.x to 7.x.. After doing so they are no longer seeing their external calls. It looks like this is likely related to the HttpUrlConnection instrumentation which has undergone massive refactoring from the 3.x agent version they upgraded from to the current 7.x version.

The following screenshot shows two spans that got generated by the HttpUrlConnection instrumentation but neither has an external call associated with it. This is likely because neither of the instrumented methods in the trace, connect and getOutputStream, will result in the instrumentation calling reportAsExternal which is required to create an "External HTTP" span that will link to an external host.

Also note that calling reportAsExternal is what results in the External rollup metrics getting created. The fact that the External/{HOST}/all rollup metric is missing further confirms that reportAsExternal is never being called by the instrumentation.

external-call-issue-gh

Acceptance Criteria

Need to investigate the HTTP instrumentation to determine if there may be an issue related to the ordering of HttpUrlConnection method calls - which has been an issue in a past issue.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-5550

@kford-newrelic kford-newrelic added Q4 SC GTSE There is an associated support escalation with this issue. labels Nov 28, 2022
@workato-integration workato-integration bot changed the title External HTTP requests sometimes captured as Uknown External HTTP requests missing /External/{host}/all rollup metric Nov 28, 2022
@kford-newrelic kford-newrelic added on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter and removed Q4 SC labels Nov 30, 2022
@kford-newrelic
Copy link
Contributor Author

Targeted for the Jan-Mar quarter

@jasonjkeller jasonjkeller mentioned this issue Dec 9, 2022
Merged
@workato-integration
Copy link

Jira CommentId: 126375
Commented by jkeller:

This should be addressed by this PR: #1102

@jasonjkeller jasonjkeller self-assigned this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonjkeller jasonjkeller

Labels
GTSE There is an associated support escalation with this issue. on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NR-70183 httpurlconnection fix newrelic/newrelic-java-agent
2 participants
@jasonjkeller @kford-newrelic