From 43dac1f1d5f7e7e8a3951ba7c30d89af2131fa44 Mon Sep 17 00:00:00 2001 From: Reuben Mangubat Date: Tue, 26 Jul 2022 15:30:01 +0800 Subject: [PATCH] Fix distorted ID PASS branding in older android devices --- .../org/newlogic/smartscanner/MainActivity.kt | 2 +- .../result/IDPassResultActivity.kt | 6 ++-- .../res/layout/activity_idpass_result.xml | 12 ++++---- app/src/main/res/layout/activity_result.xml | 14 ++++----- app/src/main/res/layout/item_barcode.xml | 8 ++--- app/src/main/res/layout/item_idpass_lite.xml | 8 ++--- app/src/main/res/layout/item_mrz.xml | 8 ++--- app/src/main/res/layout/item_nfc.xml | 8 ++--- app/src/main/res/layout/item_qr.xml | 8 ++--- app/src/main/res/layout/sheet_qrcode.xml | 6 ++-- .../smartscanner/lib/SmartScannerActivity.kt | 30 +++++++++---------- .../smartscanner/lib/nfc/NFCFragment.kt | 2 +- .../layout-land/activity_smart_scanner.xml | 30 +++++++++---------- .../main/res/layout/activity_nfc_scanner.xml | 2 +- .../res/layout/activity_smart_scanner.xml | 30 +++++++++---------- .../main/res/layout/dialog_idpass_verify.xml | 16 +++++----- core-lib/src/main/res/layout/fragment_nfc.xml | 8 ++--- .../res/layout/fragment_passport_details.xml | 4 +-- 18 files changed, 101 insertions(+), 101 deletions(-) diff --git a/app/src/main/java/org/newlogic/smartscanner/MainActivity.kt b/app/src/main/java/org/newlogic/smartscanner/MainActivity.kt index 05001e5e..bcc4c7cc 100644 --- a/app/src/main/java/org/newlogic/smartscanner/MainActivity.kt +++ b/app/src/main/java/org/newlogic/smartscanner/MainActivity.kt @@ -72,7 +72,7 @@ class MainActivity : AppCompatActivity() { binding.itemBarcode.item.setOnClickListener { scanBarcode(BarcodeOptions.default) } binding.itemIdpassLite.item.setOnClickListener { scanIDPassLite() } binding.itemMrz.item.setOnClickListener { scanMRZ() } - binding.itemQR.item.setOnClickListener { scanQRCode() } + binding.itemQr.item.setOnClickListener { scanQRCode() } binding.itemNfc.item.setOnClickListener { scanNFC() } // Change language binding.languageSettings.setOnClickListener { diff --git a/app/src/main/java/org/newlogic/smartscanner/result/IDPassResultActivity.kt b/app/src/main/java/org/newlogic/smartscanner/result/IDPassResultActivity.kt index cf834fc1..fdc59a3f 100755 --- a/app/src/main/java/org/newlogic/smartscanner/result/IDPassResultActivity.kt +++ b/app/src/main/java/org/newlogic/smartscanner/result/IDPassResultActivity.kt @@ -60,7 +60,7 @@ class IDPassResultActivity : AppCompatActivity(), View.OnClickListener { setContentView(R.layout.activity_idpass_result) // Initialize UI val toolbar : Toolbar? = findViewById(R.id.toolbar) - val pinCodeBtn: Button = findViewById(R.id.pinCodeAuth) + val pinCodeBtn: Button = findViewById(R.id.pin_code_auth) pinCodeBtn.setOnClickListener(this) // Setup toolbar setSupportActionBar(toolbar) @@ -197,8 +197,8 @@ class IDPassResultActivity : AppCompatActivity(), View.OnClickListener { override fun onClick(v: View?) { when (v?.id) { - R.id.pinCodeAuth -> { - val cardpincode = findViewById(R.id.cardPinCode) + R.id.pin_code_auth -> { + val cardpincode = findViewById(R.id.card_pin_code) pinCode = cardpincode.text.toString() displayResult(qrBytes) hideKeyboard(cardpincode) diff --git a/app/src/main/res/layout/activity_idpass_result.xml b/app/src/main/res/layout/activity_idpass_result.xml index 2a15afe2..f904d47a 100755 --- a/app/src/main/res/layout/activity_idpass_result.xml +++ b/app/src/main/res/layout/activity_idpass_result.xml @@ -4,10 +4,10 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" - tools:context="org.idpass.smartscanner.org.newlogic.smartscanner.result.IDPassResultActivity"> + tools:context="org.newlogic.smartscanner.result.IDPassResultActivity"> + app:layout_constraintTop_toBottomOf="@+id/layout" /> + app:layout_constraintTop_toBottomOf="@+id/card_pin_code" /> \ No newline at end of file diff --git a/app/src/main/res/layout/activity_result.xml b/app/src/main/res/layout/activity_result.xml index f0c11c0b..5f675da0 100755 --- a/app/src/main/res/layout/activity_result.xml +++ b/app/src/main/res/layout/activity_result.xml @@ -7,7 +7,7 @@ tools:context="org.newlogic.smartscanner.result.ResultActivity"> + app:layout_constraintTop_toBottomOf="@+id/txt_barcode" /> diff --git a/app/src/main/res/layout/item_idpass_lite.xml b/app/src/main/res/layout/item_idpass_lite.xml index 358a83d7..a657f299 100644 --- a/app/src/main/res/layout/item_idpass_lite.xml +++ b/app/src/main/res/layout/item_idpass_lite.xml @@ -11,7 +11,7 @@ android:paddingTop="16dp"> + app:layout_constraintTop_toBottomOf="@+id/txt_idpass" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_mrz.xml b/app/src/main/res/layout/item_mrz.xml index 053ce71e..78ef4706 100644 --- a/app/src/main/res/layout/item_mrz.xml +++ b/app/src/main/res/layout/item_mrz.xml @@ -11,7 +11,7 @@ android:paddingTop="16dp"> + app:layout_constraintTop_toBottomOf="@+id/txt_mrz" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_nfc.xml b/app/src/main/res/layout/item_nfc.xml index 4cfc18b8..f0a79f86 100644 --- a/app/src/main/res/layout/item_nfc.xml +++ b/app/src/main/res/layout/item_nfc.xml @@ -11,7 +11,7 @@ android:paddingTop="16dp"> + app:layout_constraintTop_toBottomOf="@+id/txt_nfc" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_qr.xml b/app/src/main/res/layout/item_qr.xml index 5d513693..67cf11d5 100644 --- a/app/src/main/res/layout/item_qr.xml +++ b/app/src/main/res/layout/item_qr.xml @@ -11,7 +11,7 @@ android:paddingTop="16dp"> + app:layout_constraintTop_toBottomOf="@+id/txt_qr" /> \ No newline at end of file diff --git a/app/src/main/res/layout/sheet_qrcode.xml b/app/src/main/res/layout/sheet_qrcode.xml index dbb961e5..25bf5592 100644 --- a/app/src/main/res/layout/sheet_qrcode.xml +++ b/app/src/main/res/layout/sheet_qrcode.xml @@ -8,7 +8,7 @@ app:layout_behavior="android.support.design.widget.BottomSheetBehavior"> { + R.id.manual_capture -> { // hide capture button during image capture manualCapture?.isEnabled = false val imageFile = File(cacheImagePath()) @@ -602,9 +602,9 @@ class SmartScannerActivity : BaseActivity(), OnClickListener { // id pass reader val reader = IDPassManager.getIDPassReader() // bottom sheet ids - val pinCodeInpt = sheetView.findViewById(R.id.cardPinCode) - val verifyBtn = sheetView.findViewById