Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to be brand agnostic #8

Closed
circlecube opened this issue Aug 4, 2023 · 1 comment
Closed

Update test to be brand agnostic #8

circlecube opened this issue Aug 4, 2023 · 1 comment

Comments

@circlecube
Copy link
Member

The notifications tests need to be updated to be brand agnostic. These notification test fixture is bluehost specific, but the fixtures need updating to work across each brand that uses the module.

Currently, the notifications module is loaded in each brand plugin (bluehost, hostgator, crazy-domians, mojo@2 and web), but bluehost is the only plugin with tests specific to notifications, so these fixtures only address the bluehost context.

Three options could be followed to put this in place:

  1. Add notifications to the fixture for every context across every brand plugin.
  2. Include multiple fixture files and an environment var to determine which to load. There would be one specific to each brand plugin.
  3. Use environment variables to adjust the contexts in the fixture to be specific to the current plugin.

Option 1 seems to be the most simple, but I like option 2 more since it keeps the fixtures per brand contained. Then option 3 could be nice to automate it all and not have to deal with overhead of the extra examples.

@circlecube
Copy link
Member Author

This was solved with #10 and released in 1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant