You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The notifications tests need to be updated to be brand agnostic. These notification test fixture is bluehost specific, but the fixtures need updating to work across each brand that uses the module.
Currently, the notifications module is loaded in each brand plugin (bluehost, hostgator, crazy-domians, mojo@2 and web), but bluehost is the only plugin with tests specific to notifications, so these fixtures only address the bluehost context.
Three options could be followed to put this in place:
Add notifications to the fixture for every context across every brand plugin.
Include multiple fixture files and an environment var to determine which to load. There would be one specific to each brand plugin.
Use environment variables to adjust the contexts in the fixture to be specific to the current plugin.
Option 1 seems to be the most simple, but I like option 2 more since it keeps the fixtures per brand contained. Then option 3 could be nice to automate it all and not have to deal with overhead of the extra examples.
The text was updated successfully, but these errors were encountered:
The notifications tests need to be updated to be brand agnostic. These notification test fixture is bluehost specific, but the fixtures need updating to work across each brand that uses the module.
Currently, the notifications module is loaded in each brand plugin (bluehost, hostgator, crazy-domians, mojo@2 and web), but bluehost is the only plugin with tests specific to notifications, so these fixtures only address the bluehost context.
Three options could be followed to put this in place:
Option 1 seems to be the most simple, but I like option 2 more since it keeps the fixtures per brand contained. Then option 3 could be nice to automate it all and not have to deal with overhead of the extra examples.
The text was updated successfully, but these errors were encountered: