-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged WTMP changes back in and fixed reconnect IP logging #1408
Conversation
instfiles/xrdp.service
Outdated
PIDFile=/var/run/xrdp.pid | ||
EnvironmentFile=-/etc/sysconfig/xrdp | ||
EnvironmentFile=-/etc/default/xrdp | ||
ExecStart=/usr/local/sbin/xrdp $XRDP_OPTIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not hardcode /usr/local
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the file as its get build at compile time
instfiles/xrdp.service
Outdated
|
||
[Service] | ||
Type=forking | ||
PIDFile=/var/run/xrdp.pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the file as its get build at compile time
instfiles/xrdp-sesman.service
Outdated
|
||
[Service] | ||
Type=forking | ||
PIDFile=/var/run/xrdp-sesman.pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the file as its get build at compile time
instfiles/xrdp-sesman.service
Outdated
EnvironmentFile=-/etc/sysconfig/xrdp | ||
EnvironmentFile=-/etc/default/xrdp | ||
ExecStart=/usr/local/sbin/xrdp-sesman $SESMAN_OPTIONS | ||
ExecStop=/usr/local/sbin/xrdp-sesman $SESMAN_OPTIONS --kill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the file as its get build at compile time
File gets generated at compile time
File gets created at compile time
All checks now show as passed, can this be merged back in? For audit/compliance purposes this is a greatly needed feature. |
Hello, (I'm unable to have xrdp-sesman running if I don't use the nodaemon switch) |
Hi @metalefty, can this PR be merged please? |
Hi all, |
Hi @metalefty, can this pull be merged? It's key feature for multi-user roll-out. |
This should be redone after #1961. There's very few chance to get merged with current authentication architecture. |
Merged #1077 back in to the devel and added logging on reconnection from new ipaddresses