Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H264 Graphics Pipeline in XRDP #1174

Closed
antoine-roux opened this issue Jul 23, 2018 · 3 comments
Closed

H264 Graphics Pipeline in XRDP #1174

antoine-roux opened this issue Jul 23, 2018 · 3 comments

Comments

@antoine-roux
Copy link

Hello,

I'm wondering if XRDP implements the RDP 8.1 Graphics Pipeline.
I'm trying to use the /gfx-h264 of FreeRDP but it do not works with a XRDP server :(

In the XRDP source code, I can read some lines about H264 codec, but it appears to be another thing not compatible with FreeRDP. What I understand is that Graphics Pipeline's H264 is not just another codec but another channel. Am I wrong?

From FreeRDP side, I see 3 codecs: NSC, JPEG and RemoteFX
https://github.com/FreeRDP/FreeRDP/blob/59e8b6728799e46455ed0eb93a5291ea87eb464f/libfreerdp/core/capabilities.c#L83-L126

But from XRDP side, there is much more codecs.

/* Bitmap Codec: codecGUID (MS-RDPBCGR 2.2.7.2.10.1.1) */
/* CODEC_GUID_NSCODEC CA8D1BB9-000F-154F-589FAE2D1A87E2D6 */
#define XR_CODEC_GUID_NSCODEC \
"\xb9\x1b\x8d\xca\x0f\x00\x4f\x15\x58\x9f\xae\x2d\x1a\x87\xe2\xd6"
/* CODEC_GUID_REMOTEFX 76772F12-BD72-4463-AFB3B73C9C6F7886 */
#define XR_CODEC_GUID_REMOTEFX \
"\x12\x2F\x77\x76\x72\xBD\x63\x44\xAF\xB3\xB7\x3C\x9C\x6F\x78\x86"
/* CODEC_GUID_IMAGE_REMOTEFX 2744CCD4-9D8A-4E74-803C-0ECBEEA19C54 */
#define XR_CODEC_GUID_IMAGE_REMOTEFX \
"\xD4\xCC\x44\x27\x8A\x9D\x74\x4E\x80\x3C\x0E\xCB\xEE\xA1\x9C\x54"
/* MFVideoFormat_H264 0x34363248-0000-0010-800000AA00389B71 */
#define XR_CODEC_GUID_H264 \
"\x48\x32\x36\x34\x00\x00\x10\x00\x80\x00\x00\xAA\x00\x38\x9B\x71"
/* CODEC_GUID_JPEG 1BAF4CE6-9EED-430C-869ACB8B37B66237 */
#define XR_CODEC_GUID_JPEG \
"\xE6\x4C\xAF\x1B\xED\x9E\x0C\x43\x86\x9A\xCB\x8B\x37\xB6\x62\x37"
/* CODEC_GUID_PNG 0E0C858D-28E0-45DB-ADAA0F83E57CC560 */
#define XR_CODEC_GUID_PNG \
"\x8D\x85\x0C\x0E\xE0\x28\xDB\x45\xAD\xAA\x0F\x83\xE5\x7C\xC5\x60"

This sounds very interesting, but I unable to use them... Can someone tell me how to do?

Thanks,
Antoine

@blackcrack
Copy link

blackcrack commented Jul 24, 2018

i have there a link because graphic codec and a community for a free codec ,
take a look : av1aomedia.org

AV1: next generation video – The Constrained Directional Enhancement Filter

on Mozilla Hacks, a free codec for web.

best regards
Blacky

@speidy
Copy link
Member

speidy commented Sep 18, 2018

xrdp doesn't support GFX which should be implemented as virtual channel, hence no official H264 graphics in xrdp.

The codecs you mentioned is a special implementation (doesn't interoperate with standard RDP clients)

They can be used with NeutrinoRDP client only tho.

@speidy speidy closed this as completed Sep 18, 2018
@rkkoszewski
Copy link

Are there any plans to add support for this in xrdp at some point? Or is it just not possible with X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants