Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support job filtering by owner #990

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Support job filtering by owner #990

merged 3 commits into from
Aug 27, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Aug 26, 2019

Closes #987

@atemate atemate mentioned this pull request Aug 26, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #990 into master will increase coverage by 3.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   88.69%   92.57%   +3.88%     
==========================================
  Files          37       37              
  Lines        4387     4392       +5     
  Branches      649      651       +2     
==========================================
+ Hits         3891     4066     +175     
+ Misses        387      219     -168     
+ Partials      109      107       -2
Impacted Files Coverage Δ
neuromation/api/jobs.py 96.93% <100%> (+1.4%) ⬆️
neuromation/cli/job.py 88.77% <100%> (+6.05%) ⬆️
neuromation/cli/formatters/jobs.py 97.94% <0%> (+1.64%) ⬆️
neuromation/cli/utils.py 88.74% <0%> (+4.63%) ⬆️
neuromation/cli/main.py 69.8% <0%> (+4.95%) ⬆️
neuromation/api/images.py 97.67% <0%> (+6.97%) ⬆️
neuromation/cli/storage.py 80.87% <0%> (+27.89%) ⬆️
neuromation/cli/image.py 100% <0%> (+39.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bca6d...02fa63f. Read the comment docs.

atemate
atemate commented Aug 26, 2019
View reviewed changes
neuromation/cli/job.py
@@ -410,10 +410,13 @@ def job() -> None:
multiple=True,
type=click.Choice(["pending", "running", "succeeded", "failed", "all"]),
help=(
"Filter out job by status (multiple option)."
"Filter out jobs by status (multiple option)."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar

@atemate
Copy link
Contributor Author

atemate commented Aug 26, 2019

I could not find a e2e test on CLI neuro ps -- do we have one? For now, CLI-side changes in current PR left uncovered

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2019

This pull request introduces 7 alerts when merging 689314d into f6bca6d - view on LGTM.com

new alerts:

  • 4 for Module is imported with 'import' and 'import from'
  • 3 for Conflicting attributes in base classes

@atemate atemate mentioned this pull request Aug 26, 2019
Merged
asvetlov
asvetlov approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature.
Please add changenote and merge on green

@asvetlov
Copy link
Contributor

tests for neuro ps was super slow, that's why they were extracted into platform_e2e project.

@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2019

This pull request introduces 7 alerts when merging 02fa63f into f6bca6d - view on LGTM.com

new alerts:

  • 4 for Module is imported with 'import' and 'import from'
  • 3 for Conflicting attributes in base classes

@atemate atemate merged commit 1e36ca6 into master Aug 27, 2019
@atemate atemate deleted the ay/job-filtering-by-owner branch August 27, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
CLIents platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support job filtering by owner
3 participants
@atemate @asvetlov @astaff