-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support remote images with registry host:port
#939
Conversation
Hmm. Otherwise the parser is ambiguous. |
thank you @asvetlov for your idea with |
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
=========================================
+ Coverage 91.92% 92.03% +0.1%
=========================================
Files 37 37
Lines 4209 4216 +7
Branches 634 636 +2
=========================================
+ Hits 3869 3880 +11
+ Misses 230 227 -3
+ Partials 110 109 -1
Continue to review full report at Codecov.
|
if not url.scheme: | ||
parts = url.path.split("/") | ||
url = url.build( | ||
url = URL.build( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class method, IMO it's better to use class name here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changenote
I will add the changelog message to the second PR that resolves this issue: #940 |
The newest version of neuro-API
19.7.26
broke platform-monitoring: neuro-inc/platform-monitoring#70The problem was that if
registry_url
contains both host and port, still_ImageNameParser._registry
will contain onlyhost
part. Thus, parser_container_from_api
, used to parse the response forJobs.run
, will try to parse an image likelocalhost:5000/user/ubuntu:latest
as a local image not as remote (because it does not start withlocalhost/
but starts withlocalhost:5000/
).Note: one test is still xfailed due to #938
(it fails with a wrong message)