Support copying to/from non-regular files (character devices, named pipes, etc). #813
Conversation
serhiy-storchaka
changed the title
serhiy-storchaka
force-pushed
the
copy-non-regular-file
branch
from
8823852 to
6fc1552
Compare
|
the tests are failing on Windows. |
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 90.25% 90.25% -0.01%
==========================================
Files 38 38
Lines 3347 3344 -3
Branches 484 482 -2
==========================================
- Hits 3021 3018 -3
Misses 238 238
Partials 88 88
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 89.71% 88.67% -1.04%
==========================================
Files 38 38
Lines 3460 3462 +2
Branches 493 493
==========================================
- Hits 3104 3070 -34
- Misses 262 291 +29
- Partials 94 101 +7
Continue to review full report at Codecov.
|
neuromation/api/url_utils.py
Outdated
| @@ -78,7 +78,7 @@ def normalize_local_path_uri(uri: URL) -> URL: | |||
| path = path.expanduser() | |||
| if path.parents and str(path.parents[0]).startswith("~"): | |||
| raise ValueError(f"Cannot expand user for {uri}") | |||
| path = path.absolute() | |||
| path = Path.cwd() / path | |||
There was a problem hiding this comment.
This one is a bug introduced in previous changes. I did not notice the failure on Windows among the number of random errors.
| @@ -0,0 +1 @@ | |||
| `neuro storage cp` now supports copying to/from non-regular files like character devices and named pipes. In particular this allows to output the file to the stdout or get the input from the stdin (`/dev/stdout` and `/dev/stdin` on Linux, `CON` on Windows). | |||
There was a problem hiding this comment.
can we please also mention this in the command documentation?
In particularly this allows to output the file to the stdout or get the input from the stdin:
See #281.