Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor http timeouts #703

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Refactor http timeouts #703

merged 3 commits into from
Apr 11, 2019

Conversation

asvetlov
Copy link
Contributor

The PR respects --network-timeout option in logs and cp operations.

Code cleanup as a side effect.

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #703 into master will increase coverage by 1.55%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   90.43%   91.99%   +1.55%     
==========================================
  Files          40       40              
  Lines        3230     3234       +4     
  Branches      445      445              
==========================================
+ Hits         2921     2975      +54     
+ Misses        237      196      -41     
+ Partials       72       63       -9
Impacted Files Coverage Δ
neuromation/cli/job.py 91.09% <0%> (+0.42%) ⬆️
neuromation/cli/rc.py 93.43% <100%> (+0.89%) ⬆️
neuromation/api/storage.py 100% <100%> (+2.28%) ⬆️
neuromation/api/jobs.py 93.24% <100%> (+0.04%) ⬆️
neuromation/api/core.py 98.33% <100%> (+0.18%) ⬆️
neuromation/cli/storage.py 76.59% <100%> (-0.49%) ⬇️
neuromation/cli/main.py 60.91% <0%> (+0.5%) ⬆️
neuromation/cli/formatters/jobs.py 99.52% <0%> (+0.95%) ⬆️
neuromation/cli/utils.py 92.61% <0%> (+1.97%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e2deb...8260c12. Read the comment docs.

@asvetlov asvetlov merged commit c17784f into master Apr 11, 2019
@asvetlov asvetlov deleted the refactor-http-timeouts branch April 11, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants