-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated SSH-related commands from the client #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@truskovskiyk fyi |
dalazx
reviewed
Apr 9, 2019
Yes, sure. |
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 90.43% 92.19% +1.75%
==========================================
Files 40 39 -1
Lines 3230 3112 -118
Branches 445 437 -8
==========================================
- Hits 2921 2869 -52
+ Misses 237 179 -58
+ Partials 72 64 -8
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses client-side component of neuro-inc/platform-api#515
Removing the
neuro model
command, theneuro config id_rsa
subcommand and theneuro job submit --ssh
option.neuro model
command has been deprecated for a few months.neuro job submit --ssh
has been deprecated for a few months as well.neuro config id_rsa
has been hidden for quite a while and has no use cases without the commands above.