Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated SSH-related commands from the client #700

Merged
merged 8 commits into from
Apr 11, 2019

Conversation

anayden
Copy link
Contributor

@anayden anayden commented Apr 9, 2019

This PR addresses client-side component of neuro-inc/platform-api#515

Removing the neuro model command, the neuro config id_rsa subcommand and the neuro job submit --ssh option.

  • The whole neuro model command has been deprecated for a few months.
  • neuro job submit --ssh has been deprecated for a few months as well.
  • neuro config id_rsa has been hidden for quite a while and has no use cases without the commands above.

@anayden anayden requested review from asvetlov and atemate April 9, 2019 15:52
@astaff astaff added the platform label Apr 9, 2019
@dalazx
Copy link
Contributor

dalazx commented Apr 9, 2019

@truskovskiyk fyi

@dalazx
Copy link
Contributor

dalazx commented Apr 9, 2019

@anayden awesome!

should we update the changelog?
cc @asvetlov

@asvetlov
Copy link
Contributor

Yes, sure.
The change worth CHANGELOG record

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #700 into master will increase coverage by 1.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   90.43%   92.19%   +1.75%     
==========================================
  Files          40       39       -1     
  Lines        3230     3112     -118     
  Branches      445      437       -8     
==========================================
- Hits         2921     2869      -52     
+ Misses        237      179      -58     
+ Partials       72       64       -8
Impacted Files Coverage Δ
neuromation/cli/ssh_utils.py 0% <ø> (-19.15%) ⬇️
neuromation/cli/config.py 87.5% <ø> (+0.48%) ⬆️
neuromation/cli/formatters/config.py 100% <ø> (ø) ⬆️
neuromation/api/models.py 96.29% <100%> (-3.71%) ⬇️
neuromation/cli/job.py 92.22% <100%> (+1.54%) ⬆️
neuromation/cli/rc.py 93.4% <100%> (+0.86%) ⬆️
neuromation/api/jobs.py 93.42% <100%> (+0.22%) ⬆️
neuromation/cli/main.py 60.71% <100%> (+0.3%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e2deb...46dc100. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants