-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http url on submit #527
Http url on submit #527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 92.05% 92.06% +0.01%
==========================================
Files 40 40
Lines 2882 2886 +4
Branches 378 379 +1
==========================================
+ Hits 2653 2657 +4
Misses 172 172
Partials 57 57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except a small note:
e2e test is good but the change worth unit-test in tests/cli/test_formatters.py
.
The reason is: uni-test is much easier to support than heavy-weight e2e one.
From my point of view, e2e is for testing integration with the server; but if the test can be implemented in unit style without mocking etc. -- let's do it.
I don't want to block you but very appreciate writing unit-test to reduce our tech debt and simplify future maintenance.
@asvetlov I'll address your comment in this PR. thanks! |
@asvetlov addressed. sorry again. |
No problem. |
This PR add outputting of a job's HTTP URL in
neuro submit
.сс @astaff