Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several UX improvements #486

Merged
merged 23 commits into from
Feb 21, 2019
Merged

Several UX improvements #486

merged 23 commits into from
Feb 21, 2019

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Feb 8, 2019

By suggestions from @genn

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #486 into master will increase coverage by 0.01%.
The diff coverage is 95.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   91.44%   91.45%   +0.01%     
==========================================
  Files          40       40              
  Lines        2886     2925      +39     
  Branches      379      386       +7     
==========================================
+ Hits         2639     2675      +36     
  Misses        188      188              
- Partials       59       62       +3
Impacted Files Coverage Δ
python/neuromation/cli/formatters/config.py 100% <100%> (ø) ⬆️
python/neuromation/cli/formatters/jobs.py 100% <100%> (ø) ⬆️
python/neuromation/cli/job.py 97.02% <100%> (ø) ⬆️
python/neuromation/cli/main.py 58.91% <87.5%> (+5.07%) ⬆️
python/neuromation/cli/utils.py 93.75% <96.15%> (-3.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c955d8f...caa44d1. Read the comment docs.

@atemate atemate self-requested a review February 10, 2019 17:21
Copy link
Contributor

@atemate atemate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
left some comments

@asvetlov asvetlov merged commit 56863a7 into master Feb 21, 2019
@asvetlov asvetlov deleted the ux branch February 21, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants