Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply resources formatting #328

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Conversation

shagren
Copy link
Contributor

@shagren shagren commented Dec 29, 2018

Formatter for Job(container) resources, issue #319
Result will be like:

Resources
  Memory: 1024 MB
  CPU: 2.0
  GPU: 1.0 x nvidia-tesla-p4
  Additional: Extended SHM space

Not sure can GPU number be float? Like as we havent any docs about that.
Also do we need to use other that "MB" suffixes for Memory?

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #328 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   95.19%   95.24%   +0.05%     
==========================================
  Files          22       22              
  Lines        1227     1242      +15     
==========================================
+ Hits         1168     1183      +15     
  Misses         59       59
Impacted Files Coverage Δ
python/neuromation/cli/formatter.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98acda5...b0261a5. Read the comment docs.

@shagren shagren changed the title [WIP] Apply resources formatting Apply resources formatting Dec 29, 2018
@asvetlov
Copy link
Contributor

asvetlov commented Jan 3, 2019

Currently, the format is not good but it fits into the single line.
Would you refactor the output like:

Resources: memory: 1024 MB, CPU: 2.0, GPU: 1.0 x nvidia-tesla-p4, SHM: yes

@shagren
Copy link
Contributor Author

shagren commented Jan 3, 2019

@asvetlov refactored as discussed via slack

@shagren shagren merged commit b793886 into master Jan 3, 2019
@shagren shagren deleted the 319-apply-resources-formatting branch January 3, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants