Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a deprecation warning for --life-span=0 #1749

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Sep 18, 2020

An explicit positive value should be passed to avoid resource leakage.

The value could be arbitrarily big, feel free to pass 365d if it is required really.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1749 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   87.40%   87.24%   -0.17%     
==========================================
  Files          62       62              
  Lines        9061     9063       +2     
  Branches     1463     1463              
==========================================
- Hits         7920     7907      -13     
- Misses        893      905      +12     
- Partials      248      251       +3     
Flag Coverage Δ
#e2e 65.56% <50.00%> (-0.15%) ⬇️
#unit 77.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/cli/utils.py 89.11% <100.00%> (+0.06%) ⬆️
neuromation/cli/ael.py 46.19% <0.00%> (-3.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0c4cd...5aefc6d. Read the comment docs.

@asvetlov asvetlov merged commit 5ce19ad into master Sep 18, 2020
@asvetlov asvetlov deleted the deprecate-zero-lifespan branch September 18, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant