Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of --full-uri to neuro disk get #1747

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Sep 17, 2020

Closes #1742

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #1747 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage   87.34%   87.31%   -0.03%     
==========================================
  Files          62       62              
  Lines        9061     9065       +4     
  Branches     1463     1464       +1     
==========================================
+ Hits         7914     7915       +1     
- Misses        898      899       +1     
- Partials      249      251       +2     
Flag Coverage Δ
#e2e 65.38% <66.66%> (-0.27%) ⬇️
#unit 77.46% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/cli/disks.py 87.50% <66.66%> (-2.89%) ⬇️
neuromation/cli/ael.py 48.22% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a00999...8f6449e. Read the comment docs.

Copy link
Contributor

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@romasku romasku merged commit a8f9ed5 into master Sep 18, 2020
@romasku romasku deleted the rs/disk-get-full-uri branch September 18, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"neuro disk get" always outputs full URI
2 participants