Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make images.tags() returning a list of tags #1741

Closed
serhiy-storchaka opened this issue Sep 15, 2020 · 1 comment · Fixed by #1743
Closed

Make images.tags() returning a list of tags #1741

serhiy-storchaka opened this issue Sep 15, 2020 · 1 comment · Fixed by #1743

Comments

@serhiy-storchaka
Copy link
Contributor

After #899 images.tags() returns a list of images with tags instead of a list of tags (List[RemoteImage] instead of List[str]). It affected also the output of command neuro image tags which now outputs a list of full image URIs (unlike to neuro image ls which shorten URIs).

The documentation of command neuro image tags says only about a list of tags, not images. images.tags() is still not documented.

Returning a list of images from a method which does not contain "image" in name looks surprising to me. I think it would be better to make it returning a list of tags again. To help creating RemoteImage with tag we can add method RemoteImage.with_tag().

@serhiy-storchaka
Copy link
Contributor Author

serhiy-storchaka commented Sep 15, 2020

Two concurring PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant