Add disk was removed output #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
- Coverage 88.29% 88.28% -0.02%
==========================================
Files 62 62
Lines 9031 9036 +5
Branches 1457 1459 +2
==========================================
+ Hits 7974 7977 +3
+ Misses 802 801 -1
- Partials 255 258 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
neuromation/cli/disks.py
Outdated
| await root.client.disks.rm(disk_id) | ||
| if root.verbosity > 0: | ||
| click.echo(f"Disk with id: '{disk_id}' was successfully removed.") |
There was a problem hiding this comment.
I think : is not needed here grammatically.
Disk with id 'abcd-1234' was successfully removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1735