Handle errors messages from delete response stream #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romasku
force-pushed
the
rs/handle-errors-in-delete-stream
branch
from
05502a2 to
592233c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
- Coverage 87.17% 86.99% -0.18%
==========================================
Files 59 59
Lines 8808 8821 +13
Branches 1435 1438 +3
==========================================
- Hits 7678 7674 -4
- Misses 863 897 +34
+ Partials 267 250 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
reviewed
Aug 20, 2020
neuromation/api/storage.py
Outdated
| err_text = server_message["error"] | ||
| os_errno = server_message.get("errno", None) | ||
| if os_errno is not None: | ||
| os_errno = errno.__dict__.get(os_errno, os_errno) |
There was a problem hiding this comment.
I'm missed. What is errno type here?
There was a problem hiding this comment.
errno here is module instance (it comes from import errno). This is code is almost same as in _Core.request.
asvetlov
approved these changes
Aug 20, 2020
romasku
force-pushed
the
rs/handle-errors-in-delete-stream
branch
from
3ffbc26 to
5e4acc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support of neuro-inc/platform-storage-api#239