Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal_hostname_named to JobDescription #1675

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Aug 12, 2020

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1675 into master will decrease coverage by 0.17%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
- Coverage   76.78%   76.61%   -0.18%     
==========================================
  Files          59       59              
  Lines        8733     8774      +41     
  Branches     1424     1430       +6     
==========================================
+ Hits         6706     6722      +16     
- Misses       1829     1843      +14     
- Partials      198      209      +11     
Flag Coverage Δ
#unit 76.61% <76.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/api/utils.py 98.79% <ø> (ø)
neuromation/cli/topics.py 68.88% <ø> (ø)
neuromation/cli/config.py 57.40% <16.66%> (-0.46%) ⬇️
neuromation/cli/storage.py 31.57% <40.00%> (+0.01%) ⬆️
neuromation/api/jobs.py 82.61% <66.66%> (-0.21%) ⬇️
neuromation/api/storage.py 93.41% <84.61%> (-0.58%) ⬇️
neuromation/api/abc.py 100.00% <100.00%> (ø)
neuromation/cli/formatters/jobs.py 74.38% <100.00%> (-0.34%) ⬇️
neuromation/cli/formatters/storage.py 90.73% <100.00%> (+0.11%) ⬆️
neuromation/cli/asyncio_utils.py 62.25% <0.00%> (-5.97%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045d759...84ddd0b. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a changelog file.

@romasku romasku force-pushed the rs/support-internal-hostname-named branch from f3b786d to 84ddd0b Compare August 13, 2020 15:25
@romasku romasku merged commit a71033f into master Aug 13, 2020
@romasku romasku deleted the rs/support-internal-hostname-named branch August 13, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants