Implement FileStatus.uri property #1648
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 76.48% 76.50% +0.02%
==========================================
Files 57 57
Lines 8657 8666 +9
Branches 1426 1427 +1
==========================================
+ Hits 6621 6630 +9
Misses 1836 1836
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
neuromation/api/storage.py
Outdated
| base_uri: Optional[URL], values: Dict[str, Any] | ||
| ) -> FileStatus: | ||
| if base_uri is None: | ||
| uri = URL("storage://" + values["path"].lstrip("/")) |
There was a problem hiding this comment.
What if the path contains characters %, ? or #?
There was a problem hiding this comment.
Do you mean %?# in cluster or user name?
Is it allowed at all?
There was a problem hiding this comment.
Currently they are not allowed in cluster name and user name. But user can create files with arbitrary names.
There was a problem hiding this comment.
Got you.
@serhiy-storchaka please review the updated version
Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thanks @serhiy-storchaka for the very careful review! |
No description provided.