Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job tags support #1393

Merged
merged 5 commits into from
Mar 16, 2020
Merged

Job tags support #1393

merged 5 commits into from
Mar 16, 2020

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Mar 12, 2020

No description provided.

@atemate atemate mentioned this pull request Mar 13, 2020
@atemate atemate marked this pull request as ready for review March 13, 2020 14:52
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@@ -557,13 +575,17 @@ def job() -> None:
neuro ps --name my-experiments-v1 -s failed -s succeeded
neuro ps --description="my favourite job"
neuro ps -s failed -s succeeded -q
neuro ps --tag tag1 -t tag2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the only short or long version in the example (doesn't matter what form will you choose).
I believe it is less confusing, people can learn an alternative by neuro help ps easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will consider in the following-up PR.

@atemate atemate merged commit b21938b into master Mar 16, 2020
@atemate atemate deleted the ay/tags branch March 16, 2020 09:37
@atemate atemate mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants