Pager for output lists #1152
Merged
Pager for output lists #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuromation/cli/utils.py
Outdated
| for line in handled: | ||
| click.echo(str(line)) | ||
| else: | ||
| handled.extend(lines) |
There was a problem hiding this comment.
Maybe use itertools.chain()?
neuromation/cli/utils.py
Outdated
| click.echo(str(line)) | ||
| return | ||
| count = int(terminal_size[1] * 2 / 3) | ||
| handled = [i for i in itertools.islice(lines, count)] |
There was a problem hiding this comment.
It is just list(itertools.islice(lines, count)).
neuromation/cli/utils.py
Outdated
| ) -> None: | ||
| if not tty: | ||
| for line in lines: | ||
| click.echo(str(line)) |
neuromation/cli/utils.py
Outdated
| click.echo(str(line)) | ||
| else: | ||
| handled.extend(lines) | ||
| click.echo_via_pager(str(line) + "\n" for line in handled) |
There was a problem hiding this comment.
Hmm, the problem is that echo_via_pager() adds a newline at the end. So we will always get an empty line.
It can be solved by writing:
click.echo_via_pager(chain(["\n".join(handled)], (f"\n{line}" for line in lines)))
|
All comments are fixed. |
serhiy-storchaka
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output can be potentially long, the pager is auto-applied in this case.