Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce neuro config quota show #1141

Closed
dalazx opened this issue Oct 30, 2019 · 12 comments · Fixed by #1156
Closed

Introduce neuro config quota show #1141

dalazx opened this issue Oct 30, 2019 · 12 comments · Fixed by #1156
Assignees

Comments

@dalazx
Copy link
Contributor

dalazx commented Oct 30, 2019

We need to be able to communicate to our users about their quota situation.

neuro config quota show should render the current jobs run-time consumed and quota for the current user's cluster.

The information should be retrieved using neuro-inc/platform-api#901.

Optionally, the command should output a suggestion for topping up the quota.

cc @asvetlov @mariyadavydova

@asvetlov
Copy link
Contributor

It can live in config group for now.
When we implement organizations we can reconsider the command position, moving with the deprecation of previous notation is not a big deal.

@mariyadavydova
Copy link
Contributor

Totally agree, let's keep it in config group for now.

@dalazx dalazx changed the title Introduce neuro quota show Introduce neuro config quota show Oct 30, 2019
@atemate atemate assigned atemate and unassigned anayden Oct 31, 2019
@atemate
Copy link
Contributor

atemate commented Nov 7, 2019

Guys are we OK with this output format?

GPU left: 167h 23m 32s (quota: 200h 00m 00s)
CPU left:  00h 00m 32s (quota: 1000h 00m 00s)

@mariyadavydova
Copy link
Contributor

@ayushkovskiy 👍

@atemate
Copy link
Contributor

atemate commented Nov 7, 2019

Huh, we don't provide seconds for quota.. So the formatting will look like:

GPU left: 167h 23m (quota: 200h 00m)
CPU left:  00h 00m (quota: 1000h 00m)

@mariyadavydova HDYT wouldn't it look weird without seconds?

@mariyadavydova
Copy link
Contributor

@ayushkovskiy Well, that's OK. I don't think that seconds really matter here, when we speak about 100h quotas.

@atemate
Copy link
Contributor

atemate commented Nov 7, 2019

How do we format lack of quota? (quota: NaN) or (quota: not set) or (quota: None) or (quota: ∞)?

@mariyadavydova
Copy link
Contributor

The last one is the most accurate, I guess.

@atemate
Copy link
Contributor

atemate commented Nov 7, 2019

the sign looks too tiny

@mariyadavydova
Copy link
Contributor

We may simply say (quota: infinite). I don't think that this question is very important ATM, though, because those who have no quota (i.e. non-free-tier folks) will hardly ever execute this command.

@asvetlov
Copy link
Contributor

asvetlov commented Nov 7, 2019

+1 for 'infinity'. Not all terminals support Unicode symbols.

@atemate
Copy link
Contributor

atemate commented Nov 8, 2019

if quota == infinity, left is also infinity. Let's stick to this formatting:

GPU spent: 167h 23m (quota: 170h 23m, left: 03h 00m)
CPU spent:  00h 00m (quota: infinity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants