Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in may not be needed with setuptools_scm #32

Closed
niksirbi opened this issue Dec 15, 2022 · 1 comment
Closed

MANIFEST.in may not be needed with setuptools_scm #32

niksirbi opened this issue Dec 15, 2022 · 1 comment
Labels
question Further information is requested

Comments

@niksirbi
Copy link
Member

I have stumbled upon some information that MANIFEST.in is no longer needed when using setuptools_scm. This is because setuptools_scm, by default includes all version-controlled files in the sdist.
To learn more about this see the following:

Thought @adamltyson ? Getting rid of MANIFEST.in would mean that all git-tracked files (and only those) are included in the sdist. Is that a sensible thing to do?

If we don't get rid of it, I am not sure we still get the behaviour we want, due to how this interacts with setuptools_scm (see the linked issue)

@niksirbi niksirbi added the question Further information is requested label Dec 15, 2022
@adamltyson
Copy link
Member

I think we need to look into this, because there's lots of stuff that's in the repo that's shouldn't be in the sdist (test data in particular).
I read the blog that states everything in the repo should be in sdist, but I don't agree. The sdist isn't used for development, it's used for installation when there's no wheel available.

I think we'll always need to tool to determine what gets packaged and what doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants