Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for projects in service-accounts #2965

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

YevheniiSemendiak
Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak commented Apr 26, 2023

closes #2953

@YevheniiSemendiak YevheniiSemendiak changed the title Add support for projects names in service-accounts Add support for projects in service-accounts Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +73.69 🎉

Comparison is base (2209329) 0.00% compared to head (1eb22e9) 73.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2965       +/-   ##
===========================================
+ Coverage        0   73.69%   +73.69%     
===========================================
  Files           0       70       +70     
  Lines           0    12539    +12539     
  Branches        0     2308     +2308     
===========================================
+ Hits            0     9240     +9240     
- Misses          0     2980     +2980     
- Partials        0      319      +319     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/config.py 50.71% <ø> (ø)
...o-cli/src/neuro_cli/formatters/service_accounts.py 85.71% <36.36%> (ø)
neuro-sdk/src/neuro_sdk/_service_accounts.py 96.49% <60.00%> (ø)
neuro-cli/src/neuro_cli/service_accounts.py 50.00% <75.00%> (ø)

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YevheniiSemendiak YevheniiSemendiak marked this pull request as draft April 26, 2023 09:24
@YevheniiSemendiak YevheniiSemendiak marked this pull request as ready for review April 26, 2023 20:30
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YevheniiSemendiak YevheniiSemendiak merged commit 0ff55bb into master Apr 27, 2023
@YevheniiSemendiak YevheniiSemendiak deleted the ys/project-service-account branch April 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support projects in service accounts
2 participants