Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support energy schedule #2903

Merged
merged 6 commits into from
Feb 13, 2023
Merged

Support energy schedule #2903

merged 6 commits into from
Feb 13, 2023

Conversation

YevheniiSemendiak
Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak commented Feb 8, 2023 •
edited
Loading

closes #2888

I didn't change the internal config, instead used neuro-config-client to fetch a list of energy schedules within the cluster.

  • Potentially, the table format of energy schedules should be changed.
    take a look at example
  • Should I also include cluster timezone to the neuro config show --energy report?

I also need to test it with the live schedule on dev, but please take a look at the initial implementation.

@YevheniiSemendiak YevheniiSemendiak self-assigned this Feb 8, 2023
dalazx
dalazx reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

dalazx
dalazx approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@YevheniiSemendiak YevheniiSemendiak marked this pull request as ready for review February 12, 2023 14:37
@YevheniiSemendiak
Copy link
Contributor Author

YevheniiSemendiak commented Feb 12, 2023 •
edited
Loading

@dalazx , thx for the reviews!
Tests for py.37 are failing bc of bumped pre-commit hook (they've dropped support for 3.7 recently). I do not see the reason for installing previous version for pre-config for 3.7 tests, since we will drop 3.7 support for CLI too (it's EOL is scheduled for 2023-06-27). Figuring out what's wrong with neuro-config-client on windows (some tests are failing).

I'm also awaiting for energy configs in dev to test this thing (continuing in Slack).

@YevheniiSemendiak YevheniiSemendiak merged commit 85cbc72 into master Feb 13, 2023
@YevheniiSemendiak YevheniiSemendiak deleted the ys/support-energy-schedule branch February 13, 2023 11:55
YevheniiSemendiak added a commit that referenced this pull request Feb 13, 2023
@YevheniiSemendiak
amendments for @dalazx suggestions in Slack, added changelog for #2903
ed5999c
YevheniiSemendiak added a commit that referenced this pull request Feb 14, 2023
@YevheniiSemendiak @dalazx
Amendments and changelog for Energy schedules (#2903) (#2907)
0b65787 
* amendments for @dalazx suggestions in Slack, added changelog for #2903

* Update CHANGELOG.D/2903.feature

Co-authored-by: Oleksandr Danshyn <[email protected]>

---------

Co-authored-by: Oleksandr Danshyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalazx dalazx dalazx approved these changes

@zubenkoivan zubenkoivan Awaiting requested review from zubenkoivan

Assignees

@YevheniiSemendiak YevheniiSemendiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support specifying energy schedule on job submit
2 participants
@YevheniiSemendiak @dalazx